Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account number in chart of accounts #10551

Merged
merged 5 commits into from Nov 16, 2017
Merged

Account number in chart of accounts #10551

merged 5 commits into from Nov 16, 2017

Conversation

nabinhait
Copy link
Member

Fixes #6520, #7452, #8194

screen shot 2017-08-25 at 4 41 00 pm

screen shot 2017-08-25 at 4 42 22 pm

@nabinhait nabinhait force-pushed the account_number branch 3 times, most recently from 991a28b to f93ce2f Compare August 25, 2017 13:17
@mbauskar
Copy link
Contributor

@nabinhait,

Codecy and Travis build failed can you please check and fix the test cases? Closing the PR for now

@mbauskar mbauskar closed this Aug 28, 2017
@nabinhait nabinhait reopened this Sep 6, 2017
@dulhaver
Copy link
Contributor

dulhaver commented Sep 6, 2017

just wanted to say that this is a great initiative in my eyes !!!

@rmehta
Copy link
Member

rmehta commented Sep 8, 2017

Default setup must be without numbers

@dulhaver
Copy link
Contributor

Default setup must be without numbers
isn't it suffcient to have "reqd": 0 ?

@krnkris
Copy link
Contributor

krnkris commented Sep 18, 2017

@nabinhait

Checked the Hungarian Chart of accounts
all the dots (.) should be changed to dash (-) ?

How can I make sub points under point 59
Instead of 59/51 ???? just 5951-

How to indicate a section in front of a main account group?
For example: under group two one more account group include all numbering between 25-26?

In
https://charts.erpnext.com/
I can't fork from Hungarian Chart of accounts.
I get only English base account.
How can I delete my "bad" forks?

krnkris
krnkris reviewed Sep 18, 2017
View reviewed changes
erpnext/accounts/doctype/account/chart_of_accounts/verified/hu_chart_of_accounts.json
@@ -527,7 +527,7 @@
"root_type": "Liability"
},
"5. SZ\u00c1MLAOSZT\u00c1LY K\u00d6LTS\u00c9GNEMEK": {
"51 - 53 ANYAGJELLEG\u00db R\u00c1FORD\u00cdT\u00c1SOK ": {
"51 - 53. ANYAGJELLEG\u00db R\u00c1FORD\u00cdT\u00c1SOK ": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 51-53-

@krnkris
Copy link
Contributor

krnkris commented Sep 18, 2017 •
edited

May be this would be OK

I made some changes to clear out:

#10854

@justinlusg
Copy link

Just wondering if this feature is still going on?

@krnkris
Copy link
Contributor

krnkris commented Sep 21, 2017

@justinlusg

Please take a look on it:

https://discuss.erpnext.com/t/numbering-of-accounts-in-chart-of-accounts/11101

@nabinhait nabinhait self-assigned this Oct 5, 2017
@jasonbrowne
Copy link

jasonbrowne commented Oct 13, 2017 •
edited

Hi Nabinhait,
I know you all have the summit this week, but I am wondering if you have any kind of ETA as to when this will be merged? In the states we are all very excited for this feature.
thanks
Jason

@basdereus84
Copy link

Is there any planning about when this feature will be released?

@nabinhait nabinhait mentioned this pull request Nov 14, 2017
Closed
@krnkris
Copy link
Contributor

krnkris commented Nov 14, 2017

Good news:
Plant to merge in V10

Thank you @nabinhait + ERPNext develop team

@nabinhait nabinhait merged commit 46be989 into frappe:develop Nov 16, 2017
@Tropicalrambler
Copy link
Contributor

Thanks for this amazing feature. I agree, default should be without numbers. Keep it simple. However, users can add it for legal compliance where necessary. Adding it as a field allows you to show or hide it in a report anyway, depending on who the report user will be. Many thanks for this.

vishdha pushed a commit to vishdha/erpnext that referenced this pull request Nov 20, 2017
@nabinhait @vishdha
Account number in chart of accounts (frappe#10551)
8b86ded 
* Account number in chart of accounts

* Include account number while renaming account

* Test case fixed

* Standard coa with and without numbers

* Standard coa with and without numbers
@fnrfarid
Copy link

Okay, so, I tried to read all these. And I can definitely assure you guys that I haven't understand a bit about what's going on. I just want to know how am I gonna have account numbering option for my chart of accounts?

Can someone please tell me in the easiest way possible? Like, tell me to click this and that, and voila done?

@krnkris
Copy link
Contributor

krnkris commented Dec 13, 2017

@fnrfarid

Easiest way is to ask in
https://discuss.erpnext.com

Or wait until 18th of December , to get the new release of ERPNext v10.
It will be included/merged all this features.

Hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krnkris krnkris krnkris left review comments

Assignees

@nabinhait nabinhait

Labels
dont-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@nabinhait @mbauskar @dulhaver @rmehta @krnkris @justinlusg @jasonbrowne @basdereus84 @Tropicalrambler @fnrfarid